-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch service syntax #7080
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit da3cbc6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #7080 +/- ##
=======================================
Coverage 67.25% 67.25%
=======================================
Files 612 612
Lines 29860 29860
Branches 2683 2683
=======================================
Hits 20082 20082
Misses 9503 9503
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bbee60c
to
a202276
Compare
a202276
to
52f755c
Compare
52f755c
to
40697f5
Compare
40697f5
to
ca1e2f3
Compare
in fact we have a spec provider which can help to build specs... |
Can you please give me an example? |
Merge activity
|
Not sure if there is a better pattern like "macros" that can make this more generic. 🤡 also added notify impl to notification service for bs toeverything/blocksuite#7160
ca1e2f3
to
da3cbc6
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Not sure if there is a better pattern like "macros" that can make this more generic. 🤡
also added notify impl to notification service for bs
toeverything/blocksuite#7160